Made _resolve_device_id more robust when following via_devices #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed that for some users calling E3DC services resulted in a "Device is no E3DC"-Error.
Root cause:
Other (Non-E3DC) devices from other integrations can be a via_device for the E3DC.
When introducing the wallbox devices, i added the functionality in _resolve_device_id() to follow the via_device to come from the wallbox to the E3DC Hauskraftwerk. However when following the via_device, there was no additional check if the upstream-device was also in the E3DC domain.
This led in my case e.g. that the service tried to call my Fritz!Box.
Fix:
Only follow the via_device if it's type is also E3DC.